Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix activity bar unreachable in some pages #17860

Conversation

davelopez
Copy link
Contributor

Fixes #17617

The Admin Panel, Data Libraries, and Storage Dashboard will be displayed in the center panel so the Activity bar is always reachable.
In addition, Data Libraries and Admin Panel will no longer trigger a page reload.

ActivityBarAlwaysVisible

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

admin interface might be the odd duck here and would be ok without the bar, but for the sake of consistency this is great

libraries should have been in the middle pane long time ago 🎉

dragging between libraries and history when? 🫣

@martenson martenson merged commit 7155ad7 into galaxyproject:release_24.0 Mar 28, 2024
29 checks passed
@davelopez davelopez deleted the 24.0_fix_activity_bar_unreachable branch March 28, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants