Datasets refactors #17799

itisAliRH · 2024-03-20T11:48:09Z

This PR refactors the dataset components to use CompositionAPI and typescript, imports icons and bootstrap components, and more logic improvements.

How to test the changes?

(Select all options that apply)

I've included appropriate automated tests.
This is a refactoring of components with existing test coverage.
Instructions for manual testing are as follows:
1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

… import missing icons

…alues

client/src/components/Dataset/DatasetHistory.vue

itisAliRH added 7 commits March 20, 2024 12:35

🛠️: refactor DatasetHistory to use composition API and typeScript

6b979a8

🛠️: refactor DatasetList to use composition API and typeScript

8a7ceee

🎨: fix sortDesc type in GetDatasetsOptions in datasets API

1a6e103

🛠️: refactor DatasetName to use composition API, typeScript and…

3546454

… import missing icons

🛠️: refactor DatasetName test to typeScript

c775fff

🛠️: import missing icons and components in DatasetPermissionsForm

6be4025

🎨: update applyFilters in historyStore signature to accept number v…

b7f3c9f

…alues

github-actions bot added this to the 24.1 milestone Mar 20, 2024

itisAliRH added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Mar 20, 2024

davelopez reviewed Mar 20, 2024

View reviewed changes

client/src/components/Dataset/DatasetHistory.vue Outdated Show resolved Hide resolved

🛠️: add HDASummary type to datasetsAPIs and update usages

cd0f2b8

guerler approved these changes Mar 22, 2024

View reviewed changes

ahmedhamidawan merged commit 44a2583 into galaxyproject:dev Mar 22, 2024
30 checks passed

itisAliRH deleted the datasets-refactors branch March 24, 2024 15:06