Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[24.0] Fix contentitem display routing. #17687

Merged

Conversation

dannon
Copy link
Member

@dannon dannon commented Mar 13, 2024

Should fix selenium failures in 24.0 and dev.

Also documents the ts-ignore usage more explicitly. We use a custom push method that has a different signature, hence the ts-ignores which can be removed with the migration to vue-router4 and native 'force' arg. I guess we could jump through the hoops to declare the right types here, but the swap to vue-router4 is active in the vue3 branch and very limited, specific, short-lived use of ts-ignore seems fine here.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

different signature, hence the ts-ignores which can be removed with the
migration to vue-router4 and native 'force' arg.
@github-actions github-actions bot added this to the 24.1 milestone Mar 13, 2024
@mvdbeek mvdbeek merged commit c72e928 into galaxyproject:release_24.0 Mar 13, 2024
29 checks passed
@galaxyproject galaxyproject deleted a comment from github-actions bot Mar 13, 2024
@jdavcs jdavcs modified the milestones: 24.1, 24.0 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants