[24.0] Fix contentitem display routing. #17687
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix selenium failures in 24.0 and dev.
Also documents the ts-ignore usage more explicitly. We use a custom push method that has a different signature, hence the ts-ignores which can be removed with the migration to vue-router4 and native 'force' arg. I guess we could jump through the hoops to declare the right types here, but the swap to vue-router4 is active in the vue3 branch and very limited, specific, short-lived use of ts-ignore seems fine here.
How to test the changes?
(Select all options that apply)
License