Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection components refactors #17647

Merged

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Mar 8, 2024

This PR refactors all the collection components except PairedListCollectionCreator to use CompositionAPI and typescript, imports icons and bootstrap components, and more logic improvements.

REQUIRED: #17571

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH force-pushed the collection-components-refactors branch from 7d8f723 to b5482ad Compare March 13, 2024 10:08
@itisAliRH itisAliRH changed the title [WIP] Collection components refactors Collection components refactors Mar 13, 2024
@itisAliRH itisAliRH marked this pull request as ready for review March 13, 2024 11:56
@github-actions github-actions bot added this to the 24.1 milestone Mar 13, 2024
@itisAliRH itisAliRH force-pushed the collection-components-refactors branch from b5482ad to 67214ea Compare March 13, 2024 12:54
@bgruening
Copy link
Member

Thanks for the review John and thanks @itisAliRH for all your cleanup work.

@bgruening bgruening merged commit b3ccb04 into galaxyproject:dev Apr 4, 2024
29 of 30 checks passed
@itisAliRH itisAliRH deleted the collection-components-refactors branch April 4, 2024 18:30
@bgruening bgruening added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Apr 4, 2024
@itisAliRH
Copy link
Member Author

itisAliRH commented Apr 5, 2024

There are some TypeScript errors on dev after this PR got merged related to the HDCADetailed type, which is used in PairCollectionCreator and ListCollectionCreator. Previously, the type could have any properties due to the presence of the line [key: string]: unknown | undefined;, which has since been removed here.

Based on my understanding, _uid did not exist or was not used before here and needs to be replaced with something else. We need a type to replace which should have the following:

history_content_type: "dataset_collection";
purged: boolean;
state: components["schemas"]["DatasetState"];

I will fix it and make the necessary changes to another PR and I would greatly appreciate any help!

@mvdbeek
Copy link
Member

mvdbeek commented Apr 5, 2024

ased on my understanding, _uid

that's a leftover from the old backbone history panel, all occurences of this can be replaced

@galaxyproject galaxyproject deleted a comment from github-actions bot Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants