Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login components refactors #17564

Merged
merged 16 commits into from
Mar 12, 2024
Merged

Login components refactors #17564

merged 16 commits into from
Mar 12, 2024

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Feb 28, 2024 •
edited
Loading

This PR refactors login and register related components into CompositionAPI and typescript, imports bootstrap components, and more logic improvements.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

itisAliRH added 11 commits March 7, 2024 16:58
@itisAliRH itisAliRH marked this pull request as ready for review March 8, 2024 10:48
@github-actions github-actions bot added this to the 24.1 milestone Mar 8, 2024
@ahmedhamidawan
refactor ExternalLogin to composition api + ts
53ceaab
@ahmedhamidawan
make login and register field required, add negative state to pwd
826c997 
In case the user types in an invalid password, change the `BFormInput` state to `false` as a visual indicator.
ahmedhamidawan
ahmedhamidawan approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you!!

@ahmedhamidawan ahmedhamidawan merged commit 3da05e3 into galaxyproject:dev Mar 12, 2024
36 of 37 checks passed
@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Mar 12, 2024
@galaxyproject galaxyproject deleted a comment from github-actions bot Mar 12, 2024
@itisAliRH itisAliRH deleted the login-refactors branch March 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedhamidawan ahmedhamidawan ahmedhamidawan approved these changes

Assignees
No one assigned
Labels
area/testing/selenium area/testing kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.1
Development

Successfully merging this pull request may close these issues.
3 participants
@itisAliRH @ahmedhamidawan @nsoranzo