Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Workflow Import components #17495

Merged
merged 11 commits into from
Feb 29, 2024

Conversation

itisAliRH
Copy link
Member

@itisAliRH itisAliRH commented Feb 19, 2024

This PR refactors workflow import related components into CompositionAPI and typescript, imports icons and bootstrap components, and more logic improvements.

List of the changed files
  • components/Workflow/WorkflowImport.vue
  • components/Workflow/Import/FromFileOrUrl.test.ts
  • components/Workflow/Import/FromFileOrUrl.vue
  • components/Workflow/Import/TrsImport.vue
  • components/Workflow/Import/TrsSearch.vue
  • components/Workflow/Import/TrsServerSelection.vue
  • components/Workflow/Import/TrsTool.vue
  • components/Workflow/Import/TrsUrlImport.vue

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@itisAliRH itisAliRH marked this pull request as ready for review February 20, 2024 10:57
@github-actions github-actions bot added this to the 24.0 milestone Feb 20, 2024
@itisAliRH itisAliRH marked this pull request as draft February 23, 2024 13:04
@itisAliRH itisAliRH marked this pull request as ready for review February 26, 2024 14:11
@itisAliRH itisAliRH requested a review from davelopez February 28, 2024 12:34
@jmchilton jmchilton merged commit 730494c into galaxyproject:dev Feb 29, 2024
30 checks passed
Copy link

This PR was merged without a "kind/" label, please correct.

@nsoranzo nsoranzo added the kind/refactoring cleanup or refactoring of existing code, no functional changes label Feb 29, 2024
@itisAliRH itisAliRH deleted the workflow-import-refactor branch March 1, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants