-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for a regression change - auto-select/highlight file name text #17466
Fix for a regression change - auto-select/highlight file name text #17466
Conversation
…input field for usability; change was lost when not carried over to newer code platform from https://github.com/galaxyproject/galaxy/blob/release_23.1/client/src/mvc/upload/default/default-row.js#L139
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Works well!
Do you want to target 23.2 or should we backport it? Your call :)
@davelopez Thanks for asking - let's target 23.2 :) |
@hujambo-dunia you need to force push your branch then with this commit rebased/cherry picked on top of 23.2 branch |
@martenson Ah, yes, it was unclear to me who is responsible for 23.2 branch updates. Thanks for the clarification. |
@davelopez On second thought, I think merging in |
thanks @hujambo-dunia |
No worries @hujambo-dunia! I will backport it to 23.2 since this is a bug detected on that version. |
[23.2] Fix auto-select of file name in upload (Backport of #17466)
Thanks @davelopez! |
Addresses #17394 regression. Change was lost when not carried over to newer code platform from https://github.com/galaxyproject/galaxy/blob/release_23.1/client/src/mvc/upload/default/default-row.js#L139
How to test the changes?
(Select all options that apply)
License