Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for a regression change - auto-select/highlight file name text #17466

Merged

Conversation

hujambo-dunia
Copy link
Contributor

@hujambo-dunia hujambo-dunia commented Feb 14, 2024

Addresses #17394 regression. Change was lost when not carried over to newer code platform from https://github.com/galaxyproject/galaxy/blob/release_23.1/client/src/mvc/upload/default/default-row.js#L139

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Works well!

Do you want to target 23.2 or should we backport it? Your call :)

@hujambo-dunia
Copy link
Contributor Author

Thank you! Works well!

Do you want to target 23.2 or should we backport it? Your call :)

@davelopez Thanks for asking - let's target 23.2 :)

@martenson
Copy link
Member

@hujambo-dunia you need to force push your branch then with this commit rebased/cherry picked on top of 23.2 branch

@hujambo-dunia
Copy link
Contributor Author

@hujambo-dunia you need to force push your branch then with this commit rebased/cherry picked on top of 23.2 branch

@martenson Ah, yes, it was unclear to me who is responsible for 23.2 branch updates. Thanks for the clarification.

@hujambo-dunia
Copy link
Contributor Author

@davelopez On second thought, I think merging in dev branch is preferable. In my opinion, I don't see any reason to rush such a small change request and it's better to keep in the regular code merge pipeline.

@martenson martenson merged commit a41b578 into galaxyproject:dev Feb 15, 2024
32 checks passed
@martenson
Copy link
Member

thanks @hujambo-dunia

@davelopez
Copy link
Contributor

On second thought, I think merging in dev branch is preferable. In my opinion, I don't see any reason to rush such a small change request and it's better to keep in the regular code merge pipeline.

No worries @hujambo-dunia! I will backport it to 23.2 since this is a bug detected on that version.

mvdbeek added a commit that referenced this pull request Feb 15, 2024
[23.2] Fix auto-select of file name in upload (Backport of #17466)
@hujambo-dunia
Copy link
Contributor Author

Thanks @davelopez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

3 participants