Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only check access permissions in /api/{history_dataset_collection_id}/contents/{dataset_collection_id} #17444

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Only check access permissions in /api/{history_dataset_collection_id}/contents/{dataset_collection_id} #17444

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e8e885
fix published history collections are empty on expand
ahmedhamidawan Feb 8, 2024
f4d5e9c
remove `check_ownership` from `dataset_collections.contents`
ahmedhamidawan Feb 9, 2024
9ab00ad
add api test for hdcas in public histories being accessible
ahmedhamidawan Feb 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/galaxy/managers/collections.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,7 @@ def __get_history_collection_instance(
raise RequestParameterInvalidException("History dataset collection association not found")
# TODO: that sure looks like a bug, we can't check ownership using the history of the object we're checking ownership for ...
history = getattr(trans, "history", collection_instance.history)
if check_ownership:
if check_ownership and collection_instance.history.published is False:
self.history_manager.error_unless_owner(collection_instance.history, trans.user, current_history=history)
if check_accessible:
self.history_manager.error_unless_accessible(
Expand Down
Loading