Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow removing last value from multi select field #17403

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Allow removing last value from multi select field #17403

merged 3 commits into from
Feb 13, 2024

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Jan 31, 2024 •
edited
Loading

Fixes #17351.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added this to the 24.0 milestone Jan 31, 2024
@guerler guerler force-pushed the allow_removing_last_value branch from 5a4aa7b to f222012 Compare February 6, 2024 12:06
@guerler guerler marked this pull request as ready for review February 6, 2024 15:23
@guerler guerler requested a review from martenson February 6, 2024 15:23
@guerler guerler mentioned this pull request Feb 7, 2024
Closed
martenson
martenson approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised. Thanks @guerler for a nice improvement

@martenson martenson merged commit f62d5b4 into galaxyproject:dev Feb 13, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martenson martenson martenson approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/enhancement
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.

cannot remove the last value from multi-input field
2 participants
@guerler @martenson