Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port HistoryPanel component to composition API and typescript #17318

Merged
merged 6 commits into from
Jan 23, 2024
Merged

Port HistoryPanel component to composition API and typescript #17318

merged 6 commits into from
Jan 23, 2024

Conversation

Renni771
Copy link
Contributor

@Renni771 Renni771 commented Jan 17, 2024 •
edited
Loading

This PR ports the HistoryPanel.vue component to the composition API and makes use of typescript.

How to test the changes?

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@Renni771
Port HistoryPanel component to composition API and typescript
ab77210
@Renni771
Adjust HistoryPanel code style.
cfee065 
* Handle promises that throw.
* Extract `HistoryCounter` component function type
* Inline `onError` function call
* Add types to `updateFilterValue` function
@Renni771
Remove stubs in HistoryView component test to make tests work
a94add7
@Renni771 Renni771 marked this pull request as ready for review January 18, 2024 10:57
@github-actions github-actions bot added this to the 24.0 milestone Jan 18, 2024
ahmedhamidawan
ahmedhamidawan approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ahmedhamidawan ahmedhamidawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! This change is much needed and appreciated!!!

@ahmedhamidawan ahmedhamidawan added area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes labels Jan 22, 2024
@ahmedhamidawan ahmedhamidawan merged commit 726e648 into galaxyproject:dev Jan 23, 2024
29 of 30 checks passed
@Renni771 Renni771 deleted the port-history-panel-to-composition-api-and-typescript branch January 23, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahmedhamidawan ahmedhamidawan ahmedhamidawan approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Renni771 @ahmedhamidawan