Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollback invalidated transaction: catch them earlier #17312

Merged
merged 2 commits into from
Jan 16, 2024

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 16, 2024

This should handle the PendingRollbackError. Follow-up to #17280

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@jdavcs jdavcs added kind/bug area/jobs area/database Galaxy's database or data access layer labels Jan 16, 2024
@jdavcs jdavcs added this to the 23.2 milestone Jan 16, 2024
@jdavcs jdavcs requested review from natefoo and mvdbeek January 16, 2024 20:57
@jdavcs jdavcs merged commit 34fd0bd into galaxyproject:dev Jan 16, 2024
51 of 54 checks passed
@mvdbeek
Copy link
Member

mvdbeek commented Jan 17, 2024

I suppose you meant to target 23.2 ?

@jdavcs
Copy link
Member Author

jdavcs commented Jan 17, 2024

@mvdbeek - thank you!

@nsoranzo nsoranzo changed the title [23.2] Rollback invalidated transaction: catch them earlier Rollback invalidated transaction: catch them earlier Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer area/jobs kind/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants