Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow node connector improvements #17240

Conversation

ElectronicBlueberry
Copy link
Member

closes #17195

Makes several quality of life changes to the input connectors on workflow nodes.

  • Node drop area is now larger, expanding beyond the input connector point on every direction
  • Node drop area is now square, allowing for additional leeway when attaching connections
  • The entire node input can now be used to attach a node to
  • When a connection will be made on drop, the input is highlighted

image

image

(the cursor is a dragging hand, but my screenshot software can unfortunately not capture it in that state)

Additionally fixes two minor bugs

  • Node connector no longer snaps when snapping is active
  • Tooltip no longer appears on input nodes when empty

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@bgruening
Copy link
Member

Thanks @ElectronicBlueberry

@bgruening bgruening merged commit 67b0bb9 into galaxyproject:dev Jan 4, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highligh connection in some way when it will be successfully dropped
3 participants