Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert sample object store configuration to YAML and support configuring inline #17222

Merged
merged 3 commits into from
Jan 12, 2024

Conversation

natefoo
Copy link
Member

@natefoo natefoo commented Dec 20, 2023

You can now directly configure advanced object store configurations in object_store_config in galaxy.yml.

How to test the changes?

(Select all options that apply)

  • This is a refactoring of components with existing test coverage.

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Member

@jdavcs jdavcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another improvement to our config! Looks good.

In general, I think, the logic of type "if config file exists - read from file, else - read from galaxy.yml" should live in galaxy.config. That way (a) all config-reading and processing logic would be in one place (and we'd have well-tested code that handles any and all such use cases); and (b) we'd know that whatever is in app.config.foo is the actual configuration of foo. But that's outside the scope of this PR, of course.

@jmchilton jmchilton merged commit 18b7add into galaxyproject:dev Jan 12, 2024
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants