Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vueify Admin Groups Grid #17126

Merged
merged 8 commits into from
Dec 8, 2023
Merged

Vueify Admin Groups Grid #17126

merged 8 commits into from
Dec 8, 2023

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Dec 2, 2023 •
edited
Loading

Requires #17118. This PR replaces the legacy groups grid in the admin panel with a GridList module. Operation handlers from the admin controller have been moved to the groups manager and api.

image

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@guerler guerler added kind/enhancement area/UI-UX kind/refactoring cleanup or refactoring of existing code, no functional changes area/backend labels Dec 2, 2023
@guerler guerler added this to the 23.2 milestone Dec 2, 2023
@guerler guerler force-pushed the grids_groups_admin branch 3 times, most recently from e349e0f to a9145c3 Compare December 5, 2023 16:12
@guerler guerler force-pushed the grids_groups_admin branch from a9145c3 to 332177b Compare December 6, 2023 13:27
@guerler guerler marked this pull request as ready for review December 6, 2023 15:18
@guerler guerler force-pushed the grids_groups_admin branch 2 times, most recently from a06fb25 to 783f47d Compare December 7, 2023 10:57
@guerler guerler force-pushed the grids_groups_admin branch from 783f47d to 35bcefa Compare December 7, 2023 10:58
davelopez
davelopez approved these changes Dec 7, 2023
View reviewed changes
Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @guerler!

Test failures seem unrelated.

@guerler guerler mentioned this pull request Dec 8, 2023
Merged
4 tasks
@davelopez davelopez merged commit 6b88703 into galaxyproject:dev Dec 8, 2023
@guerler guerler deleted the grids_groups_admin branch December 8, 2023 09:26
@guerler
Copy link
Contributor Author

guerler commented Dec 8, 2023

Thank you @davelopez for the comments and review!

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelopez davelopez davelopez approved these changes

Assignees
No one assigned
Labels
area/backend area/UI-UX kind/enhancement kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Milestone
24.0
Development

Successfully merging this pull request may close these issues.
3 participants
@guerler @davelopez @mvdbeek