Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for (fast5.tar).xz binary compressed files #17106

Merged
merged 5 commits into from
Mar 1, 2024

Conversation

tuncK
Copy link
Contributor

@tuncK tuncK commented Nov 29, 2023

I recently ran into the problem of not being able to analyse fast5.tar.xz files on Galaxy (bgruening/galaxytools#1359). This PR tries to introduce the fast5.tar.xz filetype and .xz compression in addition to existing .gz, .bz2 and .zip.

How to test the changes?

(Select all options that apply)

  • [ x] I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

Copy link
Contributor

@davelopez davelopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you @tuncK!

@mvdbeek mvdbeek modified the milestones: 23.2, 24.0 Dec 19, 2023
@jdavcs
Copy link
Member

jdavcs commented Mar 1, 2024

As far as I can tell, everything is correct and the failure should not have happened. Merging now; if this breaks our validate_test_tools check, I'll fix it.
Thanks, @tuncK!

@jdavcs jdavcs merged commit 4fdc7c6 into galaxyproject:dev Mar 1, 2024
1 check failed
Copy link

github-actions bot commented Mar 1, 2024

This PR was merged without a "kind/" label, please correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants