Vueify Admin User Grid #17030
Merged
Vueify Admin User Grid #17030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guerler
force-pushed
the
grids_user_admin
branch
3 times, most recently
from
995a1c8 to
ea40538
Compare
guerler
force-pushed
the
grids_user_admin
branch
2 times, most recently
from
9580e8c to
d359c23
Compare
guerler
force-pushed
the
grids_user_admin
branch
2 times, most recently
from
1911272 to
f8a0c7f
Compare
davelopez
reviewed
Nov 30, 2023
davelopez
reviewed
Dec 1, 2023
guerler
force-pushed
the
grids_user_admin
branch
from
170b838 to
65760ed
Compare
…d as separate project
… for admin user grid
guerler
force-pushed
the
grids_user_admin
branch
from
65760ed to
a0834c0
Compare
|
Awesome, thank you for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR vueifies the admin user grid by utilizing the recently introduced
GridListcomponent. Operations which were previously handled by the admin controller have been moved to the API. The Grid controller endpoint has been degraded to only provide necessary data without details about the columns and/or operations, instead these details are specified on the client using aGridListconfiguration module. The filtering operation in the Grid controller has been replaced with a modern query which is compatible with the advanced filter component. The goal of this PR is to establish a framework which allows us to step-by-step transition all Grids away from legacy code towards FastAPI controllers and re-usable Vue components.How to test the changes?
(Select all options that apply)
License