[23.0] Extract HDA for code_file validate_input hook #16120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This does not test the HDA extraction, just shows that the remapping the job output works.
|
Nah, I don't have a good workflow at the moment. I'm only going through some old histories with failed jobs created by the Covid bot. The consensus construction WF makes use of gops tools a lot so I also need to rerun quite a few of those. That's how I noticed this. Thanks, however, for deploying this on .eu already. I've just tested again and all seems to be fine now. Thanks you for the quick fix for this special case @mvdbeek ! |
bgruening
approved these changes
May 20, 2023
|
This PR was merged without a "kind/" label, please correct. |
|
EU is now updated with this commit. Thanks @mvdbeek! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Guess code_files are still a thing ... https://github.com/galaxyproject/tools-devteam/blob/main/tool_collections/gops/basecoverage/operation_filter.py fails when accessing HDA attributes.
The adapted test just shows that rerun_remap_job_id works fine otherwise.
How to test the changes?
(Select all options that apply)
🤷♂️ i don't know how to exercise this specifically with gops tools ... probably need to conditionally fail one tool run in the database. @wm75 @bgruening do you think you can test this ?
License