Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Reports app fixes #16015

Merged
merged 3 commits into from
May 2, 2023
Merged

Conversation

dannon
Copy link
Member

@dannon dannon commented Apr 28, 2023

Fixes sparklines, closing #15965
Swaps back to d3v3 until we know what we really want to do here -- this fixes the exception in #15964, which was not actually the reason for the unstyled contents.
Fixes the masthead structure, which got left behind in refactoring for 23.0. This needs care when merging forward.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@dannon dannon marked this pull request as ready for review May 1, 2023 12:04
@github-actions github-actions bot added this to the 23.0 milestone May 1, 2023
@mvdbeek mvdbeek merged commit 89cb7ca into galaxyproject:release_23.0 May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

This PR was merged without a "kind/" label, please correct.

@mvdbeek
Copy link
Member

mvdbeek commented May 2, 2023

Thanks! Can you do the forward merge ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants