Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Allow setting auto_decompress property in staging interface #16014

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Apr 27, 2023

This allows defining inputs such as

     Drosophila_melanogaster.BDGP6.32.109_UCSC.gtf.gz:
       class: File
       location: https://zenodo.org/record/6457007/files/Drosophila_melanogaster.BDGP6.32.109_UCSC.gtf.gz
       filetype: gtf
       decompress: true

without needing to know what the server side default of auto_compress is.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

This allows defining inputs such as
```
     Drosophila_melanogaster.BDGP6.32.109_UCSC.gtf.gz:
       class: File
       location: https://zenodo.org/record/6457007/files/Drosophila_melanogaster.BDGP6.32.109_UCSC.gtf.gz
       filetype: gtf
       decompress: true
```

without needing to know what the server side default of auto_compress
is.
@martenson
Copy link
Member

nice improvement

@martenson martenson merged commit 23628cb into galaxyproject:release_23.0 Apr 28, 2023
@martenson martenson deleted the add_decompress_flag_to_staging_code branch April 28, 2023 02:15
@lldelisle
Copy link
Contributor

Thank you so much!

@bgruening
Copy link
Member

Its deployed on EU.

@mvdbeek
Copy link
Member Author

mvdbeek commented Apr 28, 2023

That is a client change and will work against older releases, but we need to release new packages.

@lldelisle
Copy link
Contributor

Its deployed on EU.

Great I confirm it works!

@mvdbeek
Copy link
Member Author

mvdbeek commented Apr 28, 2023

Then that is not related to this PR ;).

@lldelisle
Copy link
Contributor

Ah no I thought it was working but it is not...

@mvdbeek
Copy link
Member Author

mvdbeek commented Apr 28, 2023

I'll get at least the relevant packages published, I'll you know when that's done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants