Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[23.0] Fix Webhooks not rendering #15985

Merged

Conversation

ElectronicBlueberry
Copy link
Member

The phdcomics webhook on galaxy eu failed to render. After investigating the issue, I discovered this was due to missing prototype functions in webhooks.js. These seem to have been provided by backbone.js in the past, but were currently missing from the objects. Unsure where these functions were meant to be injected, I removed the use of them instead. This fixed the rendering issue.

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

  • I agree to license these and all my past contributions to the core galaxy codebase under the MIT license.

@martenson martenson merged commit 10a89a5 into galaxyproject:release_23.0 Apr 24, 2023
@martenson
Copy link
Member

Thanks @ElectronicBlueberry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants