[23.0] Display DCE in job parameter component, allow rerunning with DCE input #15744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
changed the title
mvdbeek
force-pushed
the
dce_display
branch
4 times, most recently
from
3265efb to
af47306
Compare
mvdbeek
force-pushed
the
dce_display
branch
3 times, most recently
from
bb97680 to
51bd812
Compare
Addresses part of galaxyproject#15729
If you navigate to a tool re-run url without loading a history first the tool form would be rebuilt before the tool parameters from the re-run were actually set, so you would effectively just get the default values for the tool.
It'll always pull in the first dataset in the `other_values` dict, which isn'r correct. Tool parameters at this point know how to deal with collections, so this shouldn't be neceesary.
mvdbeek
changed the title
guerler
reviewed
May 11, 2023
| @@ -47,6 +47,7 @@ export const SimpleProviderMixin = { | |||
| loading: this.loading, | |||
| item: this.item, | |||
| save: this.save, | |||
| result: this.item, | |||
There was a problem hiding this comment.
Minor redundancy here but this allows it to plug into the generic item component without additional changes. We could resolve this later in dev.
guerler
approved these changes
May 11, 2023
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes all of #15729.
The big upshot is that element identifiers are correctly preserved, which would previously be lost, because the re-run would work over HDAs without the collection element context. But this is also much more correct and is the only way to re-run parts of jobs that consume entire subcollections.
How to test the changes?
(Select all options that apply)
License