[22.01] fix startswith attribute of <options>
#14332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as documented in the xsd in addition fix galaxyproject#14324, i.e. document the `separator` attribute of options also doc that only 1MB is used and lines starting with `#` are always ignored
nsoranzo
reviewed
Jul 14, 2022
wm75
reviewed
Jul 14, 2022
Co-authored-by: Nicola Soranzo <nicola.soranzo@gmail.com>
Welcome. Note that the linter error will stay until a new version of the tool-util package is released. Any idea when this might happen @nsoranzo? |
wm75
approved these changes
Jul 19, 2022
There was a problem hiding this comment.
Looks good to me. Thanks for fixing all of this @bernt-matthias!
|
This PR was merged without a "kind/" label, please correct. |
This was referenced Aug 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as documented in the xsd (seems that this bug was there since the beginning).
If desired we can backport the fix also to older releases.
additionally:
separatorattribute of options#are always ignoredWhile working on the tests I noticed that it is impossible to select options in tests for
multiple="true"parameters if the option values contain,. For static options this is no problem (because tool devs can control the values) but it might be for dynamic options. Is this worth opening an issue?How to test the changes?
(Select all options that apply)
License