Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[22.01] Try to unit test more of DictParser in Viz component. #13385

Merged

Conversation

jmchilton
Copy link
Member

Changed a little during 22.01 release cycle - making sure did not regress.

How to test the changes?

(Select all options that apply)

License

Changed a little during 22.01 release cycle - making sure did not regress.
@mvdbeek
Copy link
Member

mvdbeek commented Feb 15, 2022

For what it's worth, #13373 is fixing #13384. There's also a unit test we did change, so while we had coverage, we shouldn't have changed it ...

@jmchilton
Copy link
Member Author

But we never had unit test coverage of the odd logic related to nested duplicate tags in DictParser.

                asJson: Any
                if element.tag == element[0].tag:
                    asJson = ListParser(element)
                else:
                    aDict = DictParser(element)
                    if element.items():
                        aDict.update(dict(element.items()))
                    asJson = aDict
                self.update({element.tag: asJson})

I'm glad the source bug was tracked down but I was just verifying this isn't a problem.

@jmchilton jmchilton changed the title [WIP] Try to unit test more of DictParser in Viz component. Try to unit test more of DictParser in Viz component. Feb 16, 2022
@github-actions github-actions bot added this to the 22.05 milestone Feb 16, 2022
@mvdbeek mvdbeek merged commit 55e067f into galaxyproject:release_22.01 Feb 17, 2022
@mvdbeek
Copy link
Member

mvdbeek commented Feb 17, 2022

Thank you!

@mvdbeek mvdbeek changed the title Try to unit test more of DictParser in Viz component. [22.01] Try to unit test more of DictParser in Viz component. Mar 6, 2022
@mvdbeek mvdbeek modified the milestones: 22.05, 22.01 Mar 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants