-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some minor changes to the dataset show_params page #11244
Changes from 13 commits
3fd04aa
023dea1
fac42f5
1f00680
d1c33c3
7e4cd2d
71d1f62
6d08759
3b9c243
c248ffa
718a692
3c5ae83
ba31769
fe70406
9c058fd
6ce88a7
80bcf5e
bd9fce4
a77b3b2
d016d43
7cff66a
33b6385
6daa29e
8d7196c
3389afc
3417847
4a96b6d
bfadef7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,11 +1,11 @@ | ||
<template> | ||
<DatasetProvider :id="hda_id" v-slot="{ item: dataset, loading }"> | ||
<div v-if="!loading"> | ||
<h3>Dataset Information</h3> | ||
<h3>Dataset Information (<a :href="'/datasets/edit?dataset_id=' + dataset.id" target="_top">edit</a>)</h3> | ||
<table id="dataset-details" class="tabletip info_data_table"> | ||
<tbody> | ||
<tr> | ||
<td>Number</td> | ||
<td>Number in history</td> | ||
OlegZharkov marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<td id="number">{{ dataset.hid }}</td> | ||
</tr> | ||
<tr> | ||
|
@@ -43,7 +43,13 @@ | |
<tr v-if="dataset.history_id"> | ||
<td>History API ID</td> | ||
<td> | ||
<div id="history_id">{{ dataset.history_id }} <decoded-id :id="dataset.history_id" /></div> | ||
<div id="history_id"> | ||
{{ dataset.history_id }} <decoded-id :id="dataset.history_id" /> (<a | ||
:href="'/histories/view?id=' + dataset.history_id" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think we want to get away from this direct navigation, but I'm not sure what the replacement is. @dannon is that how you would do this ? Might also be better to have a button for this ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess, we kinda have to deal with it for now, not sure about global Vue router status |
||
target="_top" | ||
>view</a | ||
>) | ||
</div> | ||
</td> | ||
</tr> | ||
<tr v-if="dataset.uuid"> | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,7 +6,7 @@ | |
<tr v-if="job && job.tool_id"> | ||
<td>Galaxy Tool ID:</td> | ||
<td id="galaxy-tool-id"> | ||
{{ job.tool_id }} | ||
{{ job.tool_id }} (<a :href="'/root?tool_id=' + job.tool_id" target="_top">run</a>) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you add a button here as well ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed |
||
<copy-to-clipboard | ||
message="Tool ID was copied to your clipboard" | ||
:text="job.tool_id" | ||
|
@@ -18,6 +18,24 @@ | |
<td>Galaxy Tool Version:</td> | ||
<td id="galaxy-tool-version">{{ job.tool_version }}</td> | ||
</tr> | ||
<tr v-if="job && showWorkflowInfo"> | ||
<td>Created by workflow?</td> | ||
mvdbeek marked this conversation as resolved.
Show resolved
Hide resolved
|
||
<td id="created-by-workflow">{{ job.workflow_invocation_step != None }}</td> | ||
</tr> | ||
<tr v-if="job && job.workflow_invocation_step && showWorkflowInfo"> | ||
<td>Workflow ID:</td> | ||
<td id="workflow-id"> | ||
{{ job.workflow_invocation_step.id }} (<a | ||
:href="'/workflow/display_by_id?id=' + job.workflow_invocation_step.id" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is probably the workflow id, not the Stored Workflow id. Are you sure this is correct ? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed |
||
target="_top" | ||
>view</a | ||
>) | ||
</td> | ||
</tr> | ||
<tr v-if="job && job.workflow_invocation_step && showWorkflowInfo"> | ||
<td>Invocation ID:</td> | ||
<td id="invocation-id">{{ job.workflow_invocation_step.workflow_invocation_id }}</td> | ||
</tr> | ||
<tr v-if="job && includeTimes"> | ||
<td>Created</td> | ||
<td id="created" v-if="job.create_time"> | ||
|
@@ -47,7 +65,11 @@ | |
</tr> | ||
<tr v-if="job && job.id"> | ||
<td>Job API ID:</td> | ||
<td id="encoded-job-id">{{ job.id }} <decoded-id :id="job.id" /></td> | ||
<td id="encoded-job-id"> | ||
{{ job.id }} <decoded-id :id="job.id" /> (<a :href="'/root?job_id=' + job.id" target="_top" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Can you make the rerun a button (like it is in the history panel) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed |
||
>rerun</a | ||
>) | ||
</td> | ||
</tr> | ||
<tr v-if="job && job.copied_from_job_id"> | ||
<td>Copied from Job API ID:</td> | ||
|
@@ -84,6 +106,10 @@ export default { | |
type: Boolean, | ||
default: false, | ||
}, | ||
showWorkflowInfo: { | ||
type: Boolean, | ||
default: true, | ||
}, | ||
}, | ||
created: function () { | ||
this.fetchJob(this.job_id); | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,7 +14,7 @@ const getters = { | |
|
||
const actions = { | ||
fetchJob: async ({ commit }, jobId) => { | ||
const { data } = await axios.get(`${getAppRoot()}api/jobs/${jobId}?full=true`); | ||
const { data } = await axios.get(`${getAppRoot()}api/jobs/${jobId}?full=true&view=workflow`); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is going to fetch the expensive details for every job here. You need to make the view a variable. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. addressed |
||
commit("saveJobForJobId", { jobId, job: data }); | ||
}, | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a edit button here ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed