-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make history filters horizontal #17618
Comments
Also, instead of creating a horizontal variant of the popover_filter_menu.mp4 |
My 2c is that either cancel button should have an X or be without an icon. Having different icons for the same functionality in different contexts is a source of confusion. You might also consider dropping the cancel button from these interfaces altogether since it just duplicates the functionality of the toggle dropdown button. As of the popover this might be one of the better uses for it but I would be concerned about accessibility. |
For the cancel button, i think this is a good idea, I'll just drop it |
Add a popover version of the `FilterMenu` component. This can be enabled via the `isPopover` prop. Fixes galaxyproject#17618
there is a lot of wasted space making the interface harder to navigate since the actual data are pushed to the narrow view in the bottom of the screen
Bonus points for rephrasing the "Filter on..." texts to something better and reusing the
X
as a visual for cancel instead of the loop arrow.The text was updated successfully, but these errors were encountered: