Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make history filters horizontal #17618

Closed
martenson opened this issue Mar 6, 2024 · 4 comments
Closed

make history filters horizontal #17618

martenson opened this issue Mar 6, 2024 · 4 comments
Assignees

Comments

@martenson
Copy link
Member

martenson commented Mar 6, 2024

there is a lot of wasted space making the interface harder to navigate since the actual data are pushed to the narrow view in the bottom of the screen

Bonus points for rephrasing the "Filter on..." texts to something better and reusing the X as a visual for cancel instead of the loop arrow.

Screenshot 2024-03-06 at 10 07 38 AM
@ahmedhamidawan
Copy link
Member

Is it ok if we use the faAngleDoubleUp instead of faTimes (X):
image

@ahmedhamidawan
Copy link
Member

Also, instead of creating a horizontal variant of the FilterMenu (which behaves weird because of different types/widths of potential filters for the FilterMenu), is it a better thing to have a popover version of it?:

popover_filter_menu.mp4

@martenson
Copy link
Member Author

My 2c is that either cancel button should have an X or be without an icon. Having different icons for the same functionality in different contexts is a source of confusion.

You might also consider dropping the cancel button from these interfaces altogether since it just duplicates the functionality of the toggle dropdown button.

As of the popover this might be one of the better uses for it but I would be concerned about accessibility.

@ahmedhamidawan
Copy link
Member

You might also consider dropping the cancel button from these interfaces altogether since it just duplicates the functionality of the toggle dropdown button.

For the cancel button, i think this is a good idea, I'll just drop it

ahmedhamidawan added a commit to ahmedhamidawan/galaxy that referenced this issue Mar 8, 2024
Add a popover version of the `FilterMenu` component. This can be enabled via the `isPopover` prop. Fixes galaxyproject#17618
@ahmedhamidawan ahmedhamidawan self-assigned this Mar 8, 2024
@martenson martenson moved this from Triage/Discuss to Done in UI/UX Working Group - weeklies Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants