Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exposes job.PriorityClass.value as modifiable value #451

Merged
merged 4 commits into from
Feb 16, 2024
Merged

Exposes job.PriorityClass.value as modifiable value #451

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9905ab2
Exposes job.PriorityClass.value as modifiable value
mapk-amazon Feb 15, 2024
4ed41b3
Update galaxy/templates/priorityclass-job.yaml
mapk-amazon Feb 15, 2024
dcf1770
Update galaxy/templates/priorityclass-job.yaml
mapk-amazon Feb 15, 2024
cdd1f39
Update galaxy/templates/priorityclass-job.yaml
mapk-amazon Feb 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions galaxy/templates/priorityclass-job.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ metadata:
name: {{ include "galaxy.pod-priority-class" . }}
labels:
{{- include "galaxy.labels" . | nindent 4 }}
value: -1000
value: {{ default "-1000" .Values.jobs.priorityClass.value }}
preemptionPolicy: Never
globalDefault: false
description: "Galaxy jobs will run when cluster resources are available and will not preempt existing workloads."
description: "By default, Galaxy jobs will not preempt existing workloads but will run when cluster resources are available. Depending on the cluster setup, the preemption value can be modified to prompt scaling of the cluster for the computation."
Copy link
Member

@nuwang nuwang Feb 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think some guidance on what values would elicit the desired behaviour in the autoscaler case would also be helpful. That is to say, at what priority value would the autoscaler scale up and schedule nodes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, sounds great!

{{ end }}
1 change: 1 addition & 0 deletions galaxy/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,6 +542,7 @@ jobs:
#- Assign a [priorityClass](https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass) to the dispatched jobs.
enabled: true
existingClass: ""
value: -1000
rules:
tpv_rules_local.yml:
global:
Expand Down
Loading