Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update s3-csi version to 0.35.2 #430

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Update s3-csi version to 0.35.2 #430

merged 1 commit into from
Jun 6, 2023

Conversation

nuwang
Copy link
Member

@nuwang nuwang commented Apr 26, 2023

@yegortokmakov
Copy link

FYI, for some reason this new version of the chart is not handling the empty strings in the values well, so I had to define csi-s3-secret manually outside of the csi-s3 chart. The error I was getting:

error validating "": error validating data: [unknown object type "nil" in Secret.stringData.accessKeyID, unknown object type "nil" in Secret.stringData.secretAccessKey]

and should be fixed by defining default values in the chart itself.

@yegortokmakov
Copy link

also, right now the version of the driver is hardcoded and will have to be updated as well: https://github.com/galaxyproject/galaxy-helm/blob/master/galaxy/values.yaml#L316

but again, this was a breaking change in my case.

@nuwang
Copy link
Member Author

nuwang commented Apr 28, 2023

New version of the chart is not handling the empty strings in the values well,

Which would means that default/empty IAM credentials won't work right? Sounds like a bug that needs to be fixed upstream. I guess the interim workaround is to hardcode something.

@nuwang
Copy link
Member Author

nuwang commented Apr 28, 2023

Yeah, I just remembered that I made two upstream fixes that were never merged:
yandex-cloud/k8s-csi-s3#11
yandex-cloud/k8s-csi-s3#20

Without the second one in particular, we had to manually package the chart and force the s3fs mounter. Last time I tried, the geesefs mounter had issues, in particular with caching: yandex-cloud/k8s-csi-s3#18. Looks like we may have to do that again.

The lack of traction in getting these issues fixed was one reason we added support back for cvmfs.

@ksuderman ksuderman merged commit 072b34b into master Jun 6, 2023
@ksuderman ksuderman deleted the nuwang-patch-s3fs branch June 6, 2023 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants