Make necessary changes for TPV 2.0 #405
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nuwang
changed the title
nuwang
changed the title
nuwang
force-pushed
the
upgrade_to_tpv_2
branch
from
7efadce to
4ee34f9
Compare
|
Will this work with with older Galaxy versions? I cannot find where TPV version is pinned so wondering how does an admin update from <2.0. |
|
Yes. The runner parameter will be ignored in older versions. The TPV version is constrained in Galaxy (https://github.com/galaxyproject/galaxy/blob/c54ec2f18d7a8d5fa7a73710c550ad24ecda594b/lib/galaxy/dependencies/conditional-requirements.txt#L16), but unconstrained in the container (https://github.com/galaxyproject/galaxy-docker-k8s/blob/3d0ccac59107841ff28acc2eb60e433e967fc7eb/files/k8s-requirements.txt#L3). |
afgane
approved these changes
Jan 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.