Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sets the mulled resolution cache lock dir to local #402

Merged
merged 1 commit into from
Jan 6, 2023

Conversation

pcm32
Copy link
Member

@pcm32 pcm32 commented Dec 16, 2022

The mulled cache lock dir is often accessed and it doesn't need to be on the shared file system. Then each galaxy process that needs it will have it's own and performance on local disk should be better than on the shared file system.

Helps with #399 .

Copy link
Member

@nuwang nuwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pcm32 Does the /galaxy/server/local directory need to be created beforehand? Or will the entire path be created automatically?

@pcm32
Copy link
Member Author

pcm32 commented Dec 16, 2022

On the current deployment, it created it on its own, but it was just a single level directory. I will restart my deployment with this path to confirm that the behaviour is recursive.

@pcm32
Copy link
Member Author

pcm32 commented Dec 19, 2022

I can confirm that the directories requested get created by some process without the helm chart having to take care of it.

@nuwang nuwang merged commit 33ec40b into master Jan 6, 2023
@nuwang nuwang deleted the feature/local_mulled_cache_lock branch January 6, 2023 10:40
@nuwang
Copy link
Member

nuwang commented Jan 6, 2023

Thanks @pcm32!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants