Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New 0.9.0 release #224

Closed
nsoranzo opened this issue May 3, 2017 · 11 comments
Closed

New 0.9.0 release #224

nsoranzo opened this issue May 3, 2017 · 11 comments
Assignees

Comments

@nsoranzo
Copy link
Member

nsoranzo commented May 3, 2017

Requested by @erasche in galaxy-iuc/parsec#10 . Also needed to officially support the forthcoming Galaxy release_17.05.

@afgane I've updated CHANGELOG.md, if you want to take a look. Anything outstanding from your side (apart from open pull requests)?
I can do the release this time, if you like. What's the process exactly? I've come up with the following:

# Cleanup
find . -name '*.pyc' -delete
rm -rf dist/
# Install latest versions of pip, setuptools and twine in a virtualenv
[ -f .venv/bin/activate ] || virtualenv .venv
. .venv/bin/activate
pip install --upgrade pip setuptools
pip install --upgrade twine wheel
# Create files in dist/
python setup.py sdist
python setup.py bdist_wheel
twine upload dist/*
@bgruening
Copy link
Member

@nsoranzo it can be that @afgane is on vacation for a few weeks.

@nsoranzo nsoranzo self-assigned this May 9, 2017
@nsoranzo
Copy link
Member Author

Ping @afgane

@afgane
Copy link
Contributor

afgane commented May 23, 2017

Sorry for the delay - missed this while I was away.

Looks good, and feel free to do a release @nsoranzo. As far as the process goes, what you outlined looks like it will work. I use Python 3.6 and hence don't use twine so instead just do python setup.py dist upload (requires ~/.pypirc)...

The only thing that's missing in your list is setting the version in bioblend/__init__.py before the release.

@hexylena
Copy link
Member

@afgane, twine is available for python 3. Most of us use it due to the security implications of using dist upload in the past.

@afgane
Copy link
Contributor

afgane commented May 24, 2017

My understanding was that the security issues were resolved for Py3.2+?

@hexylena
Copy link
Member

hexylena commented May 24, 2017

I read that as "only recently" = "there was a time when py3.2+ were vulnerable", not "only recently [it was resolved] which covers releases up to py3.2, after which they were secure by default". Maybe just a difference of interpretation

@nsoranzo
Copy link
Member Author

nsoranzo commented May 25, 2017

@afgane What about docs/_build/ ? Should I clean it up or run make -C doc/ html before creating the package and wheel? By looking at old releases, I'd say the latter.

@afgane
Copy link
Contributor

afgane commented May 25, 2017

I don't recall explicitly doing anything about docs/_build before a release. I'd only build them locally to check if they build properly but we quit including built content in the repo years ago.

Regardless, looks you figured it out and the release looks good! Thanks.

@afgane afgane closed this as completed May 25, 2017
@nsoranzo
Copy link
Member Author

Now also available on PyPI as both source and wheel distributions.

@bgruening
Copy link
Member

@nsoranzo thanks a lot for the release!

@nsoranzo
Copy link
Member Author

Hopefully the release process will be much faster with 04ef8e8 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants