feat: add utility batch hooks #8
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
… into feat/add-utils-hooks
dmoka
changed the base branch from
release-polkadot-v1.11.0-patch2
to
release-polkadot-v1.11.0-patch3
dmoka
changed the base branch from
release-polkadot-v1.11.0-patch3
to
release-polkadot-v1.11.0-patch4
jak-pan
reviewed
Dec 6, 2024
| @@ -468,6 +505,9 @@ pub mod pallet { | |||
| } else { | |||
| Self::deposit_event(Event::BatchCompleted); | |||
| } | |||
|
|
|||
| T::BatchPostHook::on_batch_end()?; | |||
There was a problem hiding this comment.
Should we maybe split success and fail end?
There was a problem hiding this comment.
what would be the reason for splitting?
|
Closed as the branch was corrupted somehow with a lot of merge conflict, so recreated here: #9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add pre and post hook for utility batch calls