feat: omnipool fees rework #987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jak-pan
reviewed
Feb 7, 2025
| @@ -342,6 +345,7 @@ where | |||
| <Runtime as frame_system::Config>::AccountId: From<AccountId>, | |||
| <Runtime as pallet_staking::Config>::AssetId: From<AssetId>, | |||
| <Runtime as pallet_referrals::Config>::AssetId: From<AssetId>, | |||
| MC: MultiCurrency<AccountId, CurrencyId = AssetId, Balance = Balance>, | |||
There was a problem hiding this comment.
Is this standard naming we use?
jak-pan
reviewed
Feb 7, 2025
| @@ -69,6 +73,17 @@ impl OraclePeriod { | |||
| use OraclePeriod::*; | |||
| &[Short, TenMinutes, Hour, Day, Week] | |||
| } | |||
|
|
|||
| pub const fn as_period(&self) -> u64 { | |||
There was a problem hiding this comment.
Nice but... people might be mistaken if they change this, oracle periods will change.. We should probably write test to see if it matches smoothing factors down.
martinfridrich
previously approved these changes
Feb 7, 2025
martinfridrich
approved these changes
Feb 7, 2025
jak-pan
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements changes to dynamic fee and other omnipool fee adjustments:
Spec: https://www.notion.so/hydradx/Fee-adjustments-b2447f1f5d294d8d9b4b74e353f3c098