Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add loader for Shader and ShaderChunk asset #2027

Merged
merged 46 commits into from
Nov 6, 2024

feat: code opt

9c0acf9
Select commit
Loading
Failed to load commit list.
Merged

Add loader for Shader and ShaderChunk asset #2027

feat: code opt
9c0acf9
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 6, 2024 in 0s

69.38% (-0.13%) compared to 5d147ae

View this Pull Request on Codecov

69.38% (-0.13%) compared to 5d147ae

Details

Codecov Report

Attention: Patch coverage is 26.08696% with 102 lines in your changes missing coverage. Please review.

Project coverage is 69.38%. Comparing base (5d147ae) to head (9c0acf9).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/loader/src/MaterialLoader.ts 2.50% 39 Missing ⚠️
packages/core/src/asset/ResourceManager.ts 51.51% 12 Missing and 4 partials ⚠️
packages/loader/src/ShaderChunkLoader.ts 25.00% 12 Missing ⚠️
packages/loader/src/ShaderLoader.ts 26.66% 11 Missing ⚠️
packages/core/src/Utils.ts 0.00% 3 Missing and 1 partial ⚠️
packages/loader/src/PrimitiveMeshLoader.ts 33.33% 2 Missing ⚠️
...ackages/loader/src/gltf/parser/GLTFBufferParser.ts 0.00% 2 Missing ⚠️
packages/core/src/asset/Loader.ts 66.66% 0 Missing and 1 partial ⚠️
packages/loader/src/AnimationClipLoader.ts 0.00% 1 Missing ⚠️
packages/loader/src/AnimatorControllerLoader.ts 0.00% 1 Missing ⚠️
... and 13 more
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2027      +/-   ##
==========================================
- Coverage   69.50%   69.38%   -0.13%     
==========================================
  Files         522      523       +1     
  Lines       27365    27404      +39     
  Branches     4097     4108      +11     
==========================================
- Hits        19021    19014       -7     
- Misses       6846     6882      +36     
- Partials     1498     1508      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov