The collider's rotation changes from radians to degrees

[luzhuang]

Please check if the PR fulfills these requirements

• The commit message follows our guidelines
• Tests for the changes have been added (for bug fixes / features)
• Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

Summary by CodeRabbit

• Bug Fixes
  • Corrected rotation angle calculations in wireframe rendering methods by converting degrees to radians
  • Updated camera navigation rotation logic to improve precision of pointer-based movements

[coderabbitai]

Walkthrough

The pull request introduces changes to two files: WireframeManager.ts and SphereScript.ts. In WireframeManager.ts, the modifications involve converting rotation angles from degrees to radians using MathUtil.degreeToRadian() for wireframe rendering methods. The SphereScript.ts changes alter the camera navigation rotation parameters, swapping the order of x and 0 in the Quaternion.rotationYawPitchRoll method.

Changes

File	Change Summary
packages/auxiliary-lines/src/WireframeManager.ts	Added MathUtil import and converted rotation angles to radians for addBoxColliderShapeWireframe, addSphereColliderShapeWireframe, and addCapsuleColliderShapeWireframe methods
packages/navigation-gizmo/src/SphereScript.ts	Modified camera navigation rotation parameters in _navigateCamera method

Sequence Diagram

sequenceDiagram
    participant WireframeManager
    participant MathUtil
    participant Quaternion
    
    WireframeManager->>MathUtil: Convert rotation angles
    MathUtil-->>WireframeManager: Radian values
    WireframeManager->>Quaternion: Use converted angles for rotation

Loading

Poem

🐰 Rotations dance in radiant light,
Degrees transform with mathly might!
Wireframes spin, gizmos take flight,
Precision leaps to a new height,
A rabbit's code, oh so bright! 🌟

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (2)

packages/auxiliary-lines/src/WireframeManager.ts (2)

391-396: Ensure the sphere collider rotation is properly documented.

This matches the box collider approach, so it should be fine, but remember to update any relevant docs or comments indicating that rotation is expected in degrees.

---

445-450: Consistent angle handling for the capsule collider.

Maintaining consistency across all collider types is good. Confirm that the underlying geometry assumptions match end-user expectations (e.g., horizontally vs vertically oriented capsules).

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bbb2f88 and b43af4d.

📒 Files selected for processing (2)

• packages/auxiliary-lines/src/WireframeManager.ts (4 hunks)
• packages/navigation-gizmo/src/SphereScript.ts (1 hunks)

🔇 Additional comments (2)

packages/auxiliary-lines/src/WireframeManager.ts (2)

31-32: Import for degree-radian conversion looks correct.

Good use of MathUtil to keep angle conversions centralized and consistent.

---

354-359: Verify the collider shape’s rotation input is indeed in degrees.

Converting the input angles to radians is correct if the collider shape’s rotation is stored in degrees. If rotation was already in radians, this operation would result in incorrect rotations.

[cptbtptpbcptdtptp]

+1