Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: disable and enable Stats #252

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

JujieX
Copy link
Member

@JujieX JujieX commented Jan 12, 2024

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Fix the bug that the stats won't be removed after disable this component.

@JujieX JujieX added the bug Something isn't working label Jan 12, 2024
@JujieX JujieX requested a review from gz65555 January 12, 2024 07:22
@gz65555 gz65555 merged commit 16de63a into galacean:dev/1.2 Jan 12, 2024
1 check passed
@JujieX JujieX linked an issue Jan 25, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot disable the StatsComponent during runtime.
2 participants