Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix subscription id mismtach #231

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Exca-DK
Copy link

@Exca-DK Exca-DK commented Jul 15, 2024

Closes #230

@SC4RECOIN
Copy link
Contributor

SC4RECOIN commented Aug 1, 2024

this did not fix linked issue for me
I still get cannot find websocket message handler for a new stream.... this should not happen with this change

in my opinion, this should just be a string so no assumptions are made about the size of the int
https://www.jsonrpc.org/specification states:
An identifier established by the Client that MUST contain a String, Number, or NULL value if included

or maybe use an even smaller id

// find available id
var id uint64 = 1
for ; ; id++ {
	if _, ok := c.subscriptionByRequestID[id]; !ok {
		break
	}
}

@Exca-DK
Copy link
Author

Exca-DK commented Aug 5, 2024

Hi @SC4RECOIN,

Could you please confirm if it works now? During our tests, Uint32 passed successfully. We have updated it to a string as suggested and it should still work as intended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RPC Provider Message ID Mismatch Near uint64 Limit
2 participants