Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow React 17 as peer dependency #69

Merged
merged 1 commit into from
Nov 1, 2020
Merged

Allow React 17 as peer dependency #69

merged 1 commit into from
Nov 1, 2020

Conversation

karlhorky
Copy link
Contributor

Hi @gaearon, @lourd ! Thanks for this package!

Since react-helmet has a dependency on this package, I came here to bump the peerDependencies version of react to include ^17.0.0, since I was getting these warnings:

warning "react-helmet > react-side-effect@2.1.0" has incorrect peer dependency "react@^16.3.0".

@lourd lourd merged commit b344c1d into gaearon:master Nov 1, 2020
@lourd
Copy link
Collaborator

lourd commented Nov 1, 2020

Thanks @karlhorky!

@lourd
Copy link
Collaborator

lourd commented Nov 1, 2020

Just published in v2.1.1

@karlhorky
Copy link
Contributor Author

Glad to help, thanks for the merge!

@karlhorky karlhorky deleted the patch-1 branch November 1, 2020 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants