Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add null check #861

Merged
merged 1 commit into from
Feb 17, 2018
Merged

Add null check #861

merged 1 commit into from
Feb 17, 2018

Conversation

philipnilsson
Copy link
Contributor

I'm encountering an error in babel.dev.js/exit. It's in quite a large project, and I don't have time to figure out the reason. (It fails checking a dependency called js-csp). Hoping you'll consider adding this extra check.

I'm encountering an error in `babel.dev.js/exit`. It's in quite a large project, and I don't have time to figure out the reason. (It fails checking a dependency called `js-csp`). Hoping you'll consider adding this extra check.
@codecov-io
Copy link

codecov-io commented Feb 16, 2018

Codecov Report

Merging #861 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #861   +/-   ##
=======================================
  Coverage   86.97%   86.97%           
=======================================
  Files          30       30           
  Lines         622      622           
  Branches      147      147           
=======================================
  Hits          541      541           
  Misses         65       65           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fa1d42...1a06535. Read the comment docs.

@theKashey
Copy link
Collaborator

The change looks reasonable, and I am going to merge your PR.
The only thing I am asking for - could you change your plugin code to

 exit({ node }, {file}) {
          const registrations = node[REGISTRATIONS]
          if(!registrations) {
              console.error('no program enter', file);
          }

next double check the content of that file, and roughly explain (or copy paste code here) how you created a program you can leave, but do not enter.

I can see the reason to this in the current implementation, it might be some serious bug, hiding between lines.

@theKashey theKashey merged commit 572e803 into gaearon:next Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants