Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React 16.9.0 patch support #1320

Merged
merged 5 commits into from
Aug 10, 2019
Merged

React 16.9.0 patch support #1320

merged 5 commits into from
Aug 10, 2019

Conversation

Bnaya
Copy link
Contributor

@Bnaya Bnaya commented Aug 9, 2019

Fixes #1319

I didn't really checked it. just the rest are passing (Or just failing as the few fails on master)

@Bnaya
Copy link
Contributor Author

Bnaya commented Aug 9, 2019

After re-looking at the tests - its not same tests that failing now,
And less tests are running.
Closing this PR for now

@Bnaya Bnaya closed this Aug 9, 2019
@Bnaya Bnaya reopened this Aug 9, 2019
@Bnaya
Copy link
Contributor Author

Bnaya commented Aug 9, 2019

I've re-opened it for the CI checks.
I've made small changes to the test suite, and also excluded react 15
I don't know what's the issue with REACT 15 or with the missing throws.
Probably you will know better

@theKashey
Copy link
Collaborator

I'll take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React 16.9.0 support webpack plugin
2 participants