Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add new beta 0.14 to peerDependencies #18

Closed
slorber opened this issue Jul 3, 2015 · 2 comments
Closed

add new beta 0.14 to peerDependencies #18

slorber opened this issue Jul 3, 2015 · 2 comments

Comments

@slorber
Copy link
Contributor

slorber commented Jul 3, 2015

As far as I understand, NPM messes up when trying to depend both 0.14.0-beta1 and on libraries that has declared React as a peerDependency.

For example

    "react": "0.14.0-beta1",
    "react-date-picker": "2.0.15",

Does not work well because react-date-picker has peerDependency >= 0.13.0

I've seen this commit which seems to be your solution to this problem (that I could validate on my computer for react-date-picker), so I simply add 0.14.0-beta1 to the list.
c11de6c

By the way, isn't there any better solution? Should I contact every lib author to make the change so that I'm able to use that beta? :'(

slorber added a commit to slorber/elemental that referenced this issue Jul 3, 2015
slorber added a commit to slorber/material-ui that referenced this issue Jul 3, 2015
slorber added a commit to slorber/react-tappable that referenced this issue Jul 29, 2015
This may seems to be a weird solution but has been used in other libs as well

See gaearon/react-hot-api#18
@cesarandreu
Copy link

Is there any way to make it to handle all beta versions?

@slorber
Copy link
Contributor Author

slorber commented Aug 4, 2015

@cesarandreu we are currently discussing this here: facebook/react#4542

In the meantine @gaearon I suggest you use

"peerDependencies": {
      "react": ">=0.11.0 || ^0.14.0-alpha"
},

It seems to me that ^0.14.0-alpha will cover all react alpha + betas + rc for the 0.14.0 version. At least I can effectively retrieve the new -beta3 with this as peerDependency

jonathanwmaddison pushed a commit to jonathanwmaddison/elemental that referenced this issue Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants