fix: preserve original video fps #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this has been already fixed in develop branch
…On czwartek, 26 gru 2024, 10:17, wrote:
Preserves original video FPS to avoid audio and subtitle sync issue. Some videos have 24 - 26 fps and encoding them with mp4box converts 23.976 fps which makes video a bit longer and causes audio and subtitle sync issues. You can view, comment on, or merge this pull request online at: #54 Commit Summary 3057095 fix: preserve original video fps c5c9e35 chore: adding ffprobe to dependencies File Changes (2 files) M README.md (1) M dvmkv2mp4 (9) Patch Links: https://github.com/gacopl/dvmkv2mp4/pull/54.patch https://github.com/gacopl/dvmkv2mp4/pull/54.diff — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID:
|
|
I've used latest develop branch to convert 25fps mkv to mp4 outputs 23.976 fps which extends the video by 2+ mins this might be due to mkv not having correct metadata or something else. I'm newbi tried this modified version and it solved the issue for me. I'm not sure this is a correct solution but works for me so I contributed in case other people have the same issue. Im using Mac OS, idk this might be due to dependency version differences. Using all the dependency's specified major version but latest minor version not exactly same as mentioned in the doc. |
|
There should be fps switch to override the fps i remember merging this
change. I'm any case pull should be made against develop branch
czw., 26 gru 2024, 15:43 użytkownik Manthankumar Satani <
***@***.***> napisał:
… I've used latest develop branch to convert 25fps mkv to mp4 outputs 23.976
fps which extends the video by 2+ mins this might be due to mkv not having
correct metadata or something else. I'm newbi tried this modified version
and it solved the issue for me. I'm not sure this is a correct solution but
works for me so I contributed in case other people have the same issue.
Im using Mac OS, idk this might be due to dependency version differences.
Using all the dependency's specified major version but latest minor version
not exactly same as mentioned in the doc.
—
Reply to this email directly, view it on GitHub
<#54 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AARMKIHBNPF66DTY5CXF6C32HQIXPAVCNFSM6AAAAABUG6VWOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRSHA2DGNZSGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
its against |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserves original video FPS to avoid audio and subtitle sync issue.
Some videos have 24 - 26 fps and encoding them with mp4box converts 23.976 fps which makes video a bit longer and causes audio and subtitle sync issues.