Refactor scalafix migration rewrite #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ctx.replaceSymbols also renames - ctx.replaceSymbols also removes imports - Tree.is[Comma] instead of `.syntax == ","` - Tree.collectFirst/exists from contrib module. - tokenList.leading().takeWhile to strip leading whitespace
gabro
reviewed
Sep 11, 2017
| } | ||
| } | ||
| for { | ||
| head <- t.tokens.headOption |
There was a problem hiding this comment.
are there concrete cases in which head is not safe?
There was a problem hiding this comment.
Yes, it's quite common unfortunately :/
@ "trait A".parse[Source].get.collect {
case t @ Name(_) => t.tokens.head.syntax
}
java.util.NoSuchElementException: next on empty iteratorThere was a problem hiding this comment.
wut, why isn't A the head of those tokens?
There was a problem hiding this comment.
There's a Name.Anonymous() inside the Template.self
@ template"{}"
res3: Template = Template(List(), List(), Self(_, None), List())
gabro
reviewed
Sep 11, 2017
| Symbol("_root_.cats.Foldable.sequenceU_.") -> "sequence_", | ||
| Symbol("_root_.cats.data.Func.appFuncU.") -> "appFunc", | ||
| Symbol("_root_.cats.free.FreeT.liftTU.") -> "liftT" | ||
| override def fix(ctx: RuleCtx): Patch = ctx.replaceSymbols( |
gabro
reviewed
Sep 11, 2017
| val leadingSpaces = ctx.tokenList.slice(leadingComma, t.tokens.head) | ||
| ctx.removeToken(leadingComma) + | ||
| leadingSpaces.map(ctx.removeToken).asPatch + | ||
| val leadingSpaces = ctx.tokenList.slice(leadingComma, t.tokens.last) |
There was a problem hiding this comment.
are you sure about this change? The leading spaces are the once from the leading comma to the first token non-space token, what am I missing?
There was a problem hiding this comment.
whoops, that was a relic of a failed refactoring attempt.
olafurpg
commented
Sep 11, 2017
| ) | ||
|
|
||
| private[this] def importeeName(importee: Importee): Option[Name] = |
There was a problem hiding this comment.
|
Amazing PR, thank you @olafurpg! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.syntax == ","