Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-up after dropping .NET Core 3.1/.NET 6 #328

Merged
merged 1 commit into from
Dec 21, 2024
Merged

Clean-up after dropping .NET Core 3.1/.NET 6 #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@

Beginning [10 November 2026, the in-process model for .NET apps in Azure Functions will no longer be supported][in-process-retirement-notice]. [Migrate to the isolated worked model][migrate-isolated-worker-model].

The Application Insights integration for Azure Functions `v3` and `v4` suffers from a few quirks that can lead to a huge Application Insights bill:
The Application Insights integration for Azure Functions `v4` suffers from a few quirks that can lead to a huge Application Insights bill:

- Telemetry processors are not supported, preventing developers from discarding telemetry items
- Each Function execution records a trace when starting and on completion
Expand Down
2 changes: 1 addition & 1 deletion src/AzureFunctionsTelemetry/AzureFunctionsTelemetry.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
<PackageId>AzureFunctions.Better.ApplicationInsights</PackageId>
<Title>Better Azure Functions Application Insights integration</Title>
<Authors>Gabriel Weyer</Authors>
<PackageDescription>Improve Application Insights (App Insights) integration for Azure Function v3 and v4. Automatically discard cruft telemetry emitted by Functions runtime. Add your own telemetry processors.</PackageDescription>
<PackageDescription>Improve Application Insights (App Insights) integration for Azure Function v4. Automatically discard cruft telemetry emitted by Functions runtime. Add your own telemetry processors.</PackageDescription>
<PackageTags>Azure-Functions Application-Insights App-Insights Telemetry Instrumentation Observability Save-Money</PackageTags>
<PackageProjectUrl>https://github.com/gabrielweyer/azure-functions-telemetry</PackageProjectUrl>
<PackageReadmeFile>README.md</PackageReadmeFile>
Expand Down
4 changes: 1 addition & 3 deletions ...TelemetryTests/ApplicationInsights/ApplicationInsightsServiceCollectionExtensionsTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,13 +35,11 @@ public void GivenApplicationNameProvided_ThenRegisterApplicationInitializer()
registeredTelemetryInitializers.Should().Contain(typeof(ApplicationInitializer));
}

#pragma warning disable CS8619 // I have to support both .NET Core 3.1 and .NET 6
private static List<Type> GetTelemetryInitializers(IServiceCollection serviceCollection)
private static List<Type?> GetTelemetryInitializers(IServiceCollection serviceCollection)
{
return serviceCollection
.Where(s => s.ServiceType == typeof(ITelemetryInitializer) && s.ImplementationType != null)
.Select(s => s.ImplementationType)
.ToList();
}
#pragma warning restore CS8619
}
Loading