Fix warnings introduced by .NET 8 migration

[skip-release]
gabrielweyer · Nov 18, 2023 · 7eacaec · 7eacaec
1 parent 3ee2ef0
commit 7eacaec
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/...eFunctionsTelemetry/ApplicationInsights/ApplicationInsightsServiceCollectionExtensions.cs b/...eFunctionsTelemetry/ApplicationInsights/ApplicationInsightsServiceCollectionExtensions.cs
@@ -35,6 +35,7 @@ public static IServiceCollection AddCustomApplicationInsights(
             return services;
         }
 
+#pragma warning disable CA1510 // I still have to support netstandard 2.1
         if (config == null)
         {
             throw new ArgumentNullException(nameof(config));
@@ -44,6 +45,7 @@ public static IServiceCollection AddCustomApplicationInsights(
         {
             throw new ArgumentNullException(nameof(services));
         }
+#pragma warning restore CA1510
 
         if (!string.IsNullOrWhiteSpace(config.ApplicationName))
         {
@@ -62,7 +64,7 @@ public static IServiceCollection AddCustomApplicationInsights(
         var serviceBusTriggeredFunctionName = FunctionsFinder
                 .GetServiceBusTriggeredFunctionNames(config.TypeFromEntryAssembly);
 
-        if (serviceBusTriggeredFunctionName.Any())
+        if (serviceBusTriggeredFunctionName.Count != 0)
         {
             services.AddSingleton<ITelemetryInitializer, ServiceBusRequestInitializer>();
         }

diff --git a/...TelemetryTests/ApplicationInsights/ApplicationInsightsServiceCollectionExtensionsTests.cs b/...TelemetryTests/ApplicationInsights/ApplicationInsightsServiceCollectionExtensionsTests.cs
@@ -35,11 +35,13 @@ public void GivenApplicationNameProvided_ThenRegisterApplicationInitializer()
         registeredTelemetryInitializers.Should().Contain(typeof(ApplicationInitializer));
     }
 
-    private static IReadOnlyList<Type> GetTelemetryInitializers(IServiceCollection serviceCollection)
+#pragma warning disable CS8619 // I have to support both .NET Core 3.1 and .NET 6
+    private static List<Type> GetTelemetryInitializers(IServiceCollection serviceCollection)
     {
         return serviceCollection
             .Where(s => s.ServiceType == typeof(ITelemetryInitializer) && s.ImplementationType != null)
             .Select(s => s.ImplementationType)
-            .ToList()!;
+            .ToList();
     }
+#pragma warning restore CS8619
 }