Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feat/Request]: isAnyCallLoading #155

Open
ross1296 opened this issue Jan 24, 2025 · 2 comments
Open

[Feat/Request]: isAnyCallLoading #155

ross1296 opened this issue Jan 24, 2025 · 2 comments
Labels
released on @beta

Comments

@ross1296
Copy link

https://discord.com/channels/1241018601541079070/1241018601541079073/1332375510935928833

Implement the concept of isAnyCallLoading which will return if any of the methods inside one or more withCalls() is loading.

Justification is that, at the moment, if you want to achieve this, then you have to create a computed which evaluates the xIsLoading() of each withCalls() method. Not a terrible thing, but across several stores it can be messy and require maintenance when adding or removing methods from withCalls().

Cheers!
@gabrielguerrero
Copy link
Owner

gabrielguerrero commented Jan 25, 2025 •
edited
Loading

I think I will call it withAllCallStatus or withStoreCallStatus , and that will add isAnyCallLoading areAllCallsLoaded and callErrors (array of errors)
the will be link to the status of any withCalls or withCallsStatus, as long as it is before them, the way i will work is that it also adds a _registerCallStatus and I will change withCall and withCallStatus to add the status signal if present

gabrielguerrero pushed a commit that referenced this issue Jan 26, 2025
feat(signals): implemented withAnyCallsStatus to track status changes…
845c964 
… on any call

withAnyCallsStatus adds isAnyCallLoading that returns true if any of the calls in the store are
loading and callsErrors that returns an array with the erros of any call if any

Fix #155
@gabrielguerrero gabrielguerrero mentioned this issue Jan 26, 2025
Merged
gabrielguerrero pushed a commit that referenced this issue Jan 29, 2025
feat(signals): implemented withAnyCallsStatus to track status changes…
68aea25 
… on any call

withAnyCallsStatus adds isAnyCallLoading that returns true if any of the calls in the store are
loading and callsErrors that returns an array with the erros of any call if any

Fix #155
gabrielguerrero pushed a commit that referenced this issue Jan 31, 2025
@gabrielguerrero
feat(signals): implemented withAnyCallsStatus to track status changes…
fbbe04f 
… on any call

withAnyCallsStatus adds isAnyCallLoading that returns true if any of the calls in the store are
loading and callsErrors that returns an array with the erros of any call if any

Fix #155
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 19.0.0-beta.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
released on @beta
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gabrielguerrero @ross1296