Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor withEntities* store features to allow receiving the config as a factory #120

Closed
gabrielguerrero opened this issue Jul 27, 2024 · 2 comments · Fixed by #125
Closed

Refactor withEntities* store features to allow receiving the config as a factory #120

gabrielguerrero opened this issue Jul 27, 2024 · 2 comments · Fixed by #125
Labels
enhancement New feature or request released on @beta released signals

Comments

@gabrielguerrero
Copy link
Owner

Refactor withEntities* store features to allow receiving the config as a factory, this will enable more dynamic configuration, like setting default sort or filter from a service or cookie
implement new withStore custom feature that will help to ease implementing this use case in our own custom features, but can also be use by devs to create their own custom store features that receive a factory that receives the store and returns the config
gabrielguerrero pushed a commit that referenced this issue Jul 27, 2024
feat(signals): refactor to have config factory in all store features
13b08a3 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
@gabrielguerrero gabrielguerrero mentioned this issue Jul 27, 2024
Merged
gabrielguerrero pushed a commit that referenced this issue Jul 27, 2024
feat(signals): refactor to have config factory in all store features
3aa07db 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
gabrielguerrero pushed a commit that referenced this issue Jul 27, 2024
feat(signals): refactor to have config factory in all store features
019e16c 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
@gabrielguerrero gabrielguerrero added the enhancement New feature or request label Jul 28, 2024
gabrielguerrero pushed a commit that referenced this issue Jul 29, 2024
feat(signals): refactor to have config factory in all store features
3e68b28 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
gabrielguerrero pushed a commit that referenced this issue Jul 29, 2024
feat(signals): refactor to have config factory in all store features
883d25a 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
gabrielguerrero pushed a commit that referenced this issue Jul 31, 2024
@gabrielguerrero
feat(signals): refactor to have config factory in all store features
ffb110e 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
@github-actions GitHub Actions
Copy link

🎉 This issue has been resolved in version 18.0.0-beta.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

gabrielguerrero pushed a commit that referenced this issue Aug 2, 2024
feat(signals): refactor to have config factory in all store features
dadd3dc 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
@gabrielguerrero gabrielguerrero mentioned this issue Aug 2, 2024
Merged
gabrielguerrero pushed a commit that referenced this issue Aug 2, 2024
@gabrielguerrero
feat(signals): refactor to have config factory in all store features
f903e97 
refactor to have config factory in all store features, new store feature withStore to pass the store
to custom features

Fixes #120
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 2, 2024

🎉 This issue has been resolved in version 18.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released on @beta released signals
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Beta gabrielguerrero/ngrx-traits
1 participant
@gabrielguerrero