fix(signals): fix withEntitiesSingleSelection deselect methods type

fix for withEntitiesSingleSelection to remove params of deselectEntity and deselect[Collection]Entity fix #112
gabrielguerrero · Jul 9, 2024 · 3641a04 · 3641a04
1 parent 1791286
commit 3641a04
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 6 deletions.
diff --git a/...rx-traits/signals/src/lib/with-entities-selection/with-entities-single-selection.model.ts b/...rx-traits/signals/src/lib/with-entities-selection/with-entities-single-selection.model.ts
@@ -17,17 +17,15 @@ export type NamedEntitiesSingleSelectionComputed<
 };
 export type EntitiesSingleSelectionMethods = {
   selectEntity: (options: { id: string | number }) => void;
-  deselectEntity: (options: { id: string | number }) => void;
+  deselectEntity: () => void;
   toggleEntity: (options: { id: string | number }) => void;
 };
 export type NamedEntitiesSingleSelectionMethods<Collection extends string> = {
   [K in Collection as `select${Capitalize<string & K>}Entity`]: (options: {
     id: string | number;
   }) => void;
 } & {
-  [K in Collection as `deselect${Capitalize<string & K>}Entity`]: (options: {
-    id: string | number;
-  }) => void;
+  [K in Collection as `deselect${Capitalize<string & K>}Entity`]: () => void;
 } & {
   [K in Collection as `toggle${Capitalize<string & K>}Entity`]: (options: {
     id: string | number;

diff --git a/...grx-traits/signals/src/lib/with-entities-selection/with-entities-single-selection.spec.ts b/...grx-traits/signals/src/lib/with-entities-selection/with-entities-single-selection.spec.ts
@@ -24,7 +24,7 @@ describe('withEntitiesSingleSelection', () => {
       const store = new Store();
       patchState(store, setAllEntities(mockProducts));
       store.selectEntity({ id: mockProducts[4].id });
-      store.deselectEntity({ id: mockProducts[4].id });
+      store.deselectEntity();
       expect(store.entitySelected()).toEqual(undefined);
     });
 
@@ -55,7 +55,7 @@ describe('withEntitiesSingleSelection', () => {
       const store = new Store();
       patchState(store, setAllEntities(mockProducts, { collection }));
       store.selectProductsEntity({ id: mockProducts[4].id });
-      store.deselectProductsEntity({ id: mockProducts[4].id });
+      store.deselectProductsEntity();
       expect(store.productsEntitySelected()).toEqual(undefined);
     });