Tidy up ReloadableObjectFromJson._fetch_inspect_result_json()
#536
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ReloadableObjectFromJson._fetch_inspect_result_json()
method implemented for each component is now expected to return an object loaded from JSON, rather than expecting the result from<ctr_exe> <subcmd> inspect
to always be a list.This allows removing the hack in
python_on_whales/components/manifest/cli_wrapper.py
(and avoids having to do similar forpodman pod inspect
), which looked like: