Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move most of the remaining tests to use container client fixtures #535

Merged
merged 1 commit into from
Jan 15, 2024
Merged

Move most of the remaining tests to use container client fixtures #535

merged 1 commit into from
Jan 15, 2024

Conversation

LewisGaul
Copy link
Collaborator

  • The follow commands do not exist with podman (checked with v4.6):
    • podman config
    • podman context
    • podman node
    • podman plugin
    • podman service
    • podman stack
    • podman swarm
  • The following are not run via parameterisation for now:
    • podman manifest
  • The following are updated to be parameterised:
    • podman system

The above are all updated to use docker_client or ctr_client such that --docker-exe and --podman-exe are respected.

Progress towards #353

gabrieldemarmiesse
gabrieldemarmiesse approved these changes Jan 15, 2024
View reviewed changes
Copy link
Owner

@gabrieldemarmiesse gabrieldemarmiesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@LewisGaul LewisGaul enabled auto-merge (squash) January 15, 2024 17:07
@LewisGaul LewisGaul merged commit 26302ea into gabrieldemarmiesse:master Jan 15, 2024
35 checks passed
@LewisGaul LewisGaul deleted the remaining_test_param branch January 15, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabrieldemarmiesse gabrieldemarmiesse gabrieldemarmiesse approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LewisGaul @gabrieldemarmiesse