Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for JXS file format #319

Merged
merged 4 commits into from
Sep 7, 2022

Conversation

V-R-Dighe
Copy link
Contributor

No description provided.

@V-R-Dighe
Copy link
Contributor Author

Hey @gabriel-vasile, I am requesting permission to run the workflows. Also, please look into my PR. Thanks!

Copy link
Owner

@gabriel-vasile gabriel-vasile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, PR looks good, except for 2 problems.

  1. there is already an older open PR for JXR
  2. the PR does not have testfiles

If you are keen to get this merged ASAP, then make this PR only about JXS format and add a testfile for it. I recommend you convert the JPG testfile to JXS but any other image works as long as it is released under a permissive license and it's under 300kb in size.

internal/magic/magic.go Outdated Show resolved Hide resolved
@gabriel-vasile
Copy link
Owner

I did some digging about this format. JXS is still in early stages. They decided on the magic numbers and the MIME type of the format, but they didn't yet release an actual implementation of JXS encoder. They will do this sometime in 2022 in Part 5 of the release.

Part 5 (ISO/IEC 21122-5) represents a reference software implementation (written in ISO C11) of the JPEG XS Part 1 decoder, conforming to the Part 2 profiles, levels and sublevels, as well as an exemplary encoder implementation.
Check here: https://en.wikipedia.org/wiki/JPEG_XS#Standards

@gabriel-vasile
Copy link
Owner

I opened #322 as a reminder and I will proceed to merge this as it is.

@gabriel-vasile gabriel-vasile changed the title Added support for JXR and JXS file formats Added support for JXS file format Sep 7, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #319 (6ffd7ad) into master (98f3091) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #319   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files           3        3           
  Lines         159      159           
=======================================
  Hits          151      151           
  Misses          6        6           
  Partials        2        2           
Impacted Files Coverage Δ
tree.go 50.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

gabriel-vasile
gabriel-vasile previously approved these changes Sep 7, 2022
@gabriel-vasile gabriel-vasile merged commit d9466a5 into gabriel-vasile:master Sep 7, 2022
@V-R-Dighe
Copy link
Contributor Author

I opened #322 as a reminder and I will proceed to merge this as it is.

Thank you @gabriel-vasile.
Surely, I will add the test file once the JXS implementation is released.

kodiakhq bot referenced this pull request in cloudquery/cloudquery Apr 1, 2023
…#9604)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [github.com/gabriel-vasile/mimetype](https://togithub.com/gabriel-vasile/mimetype) | indirect | patch | `v1.4.1` -> `v1.4.2` |

---

### ⚠ Dependency Lookup Warnings ⚠

Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.

---

### Release Notes

<details>
<summary>gabriel-vasile/mimetype</summary>

### [`v1.4.2`](https://togithub.com/gabriel-vasile/mimetype/releases/tag/v1.4.2)

[Compare Source](https://togithub.com/gabriel-vasile/mimetype/compare/v1.4.1...v1.4.2)

#### What's Changed

-   Improve mov detection; closes [#&#8203;302](https://togithub.com/gabriel-vasile/mimetype/issues/302) by [@&#8203;gabriel-vasile](https://togithub.com/gabriel-vasile) in [https://github.com/gabriel-vasile/mimetype/pull/304](https://togithub.com/gabriel-vasile/mimetype/pull/304)
-   \[codespell] Fix typos. by [@&#8203;mdosch](https://togithub.com/mdosch) in [https://github.com/gabriel-vasile/mimetype/pull/303](https://togithub.com/gabriel-vasile/mimetype/pull/303)
-   Detect UStar tar archives by [@&#8203;chrisnovakovic](https://togithub.com/chrisnovakovic) in [https://github.com/gabriel-vasile/mimetype/pull/308](https://togithub.com/gabriel-vasile/mimetype/pull/308)
-   add jxr support [#&#8203;155](https://togithub.com/gabriel-vasile/mimetype/issues/155) by [@&#8203;dijotmathews](https://togithub.com/dijotmathews) in [https://github.com/gabriel-vasile/mimetype/pull/312](https://togithub.com/gabriel-vasile/mimetype/pull/312)
-   Added support for JXS file format by [@&#8203;V-R-Dighe](https://togithub.com/V-R-Dighe) in [https://github.com/gabriel-vasile/mimetype/pull/319](https://togithub.com/gabriel-vasile/mimetype/pull/319)
-   Bump golang.org/x/net from 0.7.0 to 0.8.0 by [@&#8203;dependabot](https://togithub.com/dependabot) in [https://github.com/gabriel-vasile/mimetype/pull/367](https://togithub.com/gabriel-vasile/mimetype/pull/367)

#### New Contributors

-   [@&#8203;mdosch](https://togithub.com/mdosch) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/303](https://togithub.com/gabriel-vasile/mimetype/pull/303)
-   [@&#8203;chrisnovakovic](https://togithub.com/chrisnovakovic) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/308](https://togithub.com/gabriel-vasile/mimetype/pull/308)
-   [@&#8203;dijotmathews](https://togithub.com/dijotmathews) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/312](https://togithub.com/gabriel-vasile/mimetype/pull/312)
-   [@&#8203;V-R-Dighe](https://togithub.com/V-R-Dighe) made their first contribution in [https://github.com/gabriel-vasile/mimetype/pull/319](https://togithub.com/gabriel-vasile/mimetype/pull/319)

**Full Changelog**: gabriel-vasile/mimetype@v1.4.1...v1.4.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 3am on the first day of the month" (UTC), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box

---

This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xNTQuMCIsInVwZGF0ZWRJblZlciI6IjM0LjE1NC4wIn0=-->
@gabriel-vasile gabriel-vasile mentioned this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants